From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 6/7] drm/i915: find guilty batch buffer on
 ring resets
Date: Wed, 12 Jun 2013 11:17:03 +0100
Message-ID: <20130612101703.GD32648@cantiga.alporthouse.com>
References: <1371029734-10355-1-git-send-email-mika.kuoppala@intel.com>
	<1371029734-10355-6-git-send-email-mika.kuoppala@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (s16502780.onlinehome-server.info
	[87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id F2891E605D
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 12 Jun 2013 03:17:08 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1371029734-10355-6-git-send-email-mika.kuoppala@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jun 12, 2013 at 12:35:33PM +0300, Mika Kuoppala wrote:
> After hang check timer has declared gpu to be hang,
s/hang/hung/ :-p

> rings are reset. In ring reset, when clearing
> request list, do post mortem analysis to find out
> the guilty batch buffer.
> =

> Select requests for further analysis by inspecting
> the completed sequence number which has been updated
> into the HWS page. If request was completed, it can't
> be related to the hang.
> =

> For noncompleted requests mark the batch as guilty
> if the ring was not waiting and the ring head was
> stuck inside the buffer object or in the flush region
> right after the batch. For everything else, mark
> them as innocents.
> =

> v2: Fixed a typo in commit message (Ville Syrj=E4l=E4)
> =

> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---

> +static bool i915_head_inside_request(u32 acthd, u32 rs, u32 re)
> +{

Be kind to your reader and use request_start, request_end or just start,
end.
-Chris

-- =

Chris Wilson, Intel Open Source Technology Centre