From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 14/31] drm/i915: display pll hw state
 readout and checking
Date: Wed, 12 Jun 2013 14:49:07 +0100
Message-ID: <20130612134907.GF15338@strange.amr.corp.intel.com>
References: <1370432073-27634-1-git-send-email-daniel.vetter@ffwll.ch>
	<1370432073-27634-15-git-send-email-daniel.vetter@ffwll.ch>
	<20130612133123.GB15338@strange.amr.corp.intel.com>
	<20130612133914.GR5004@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
	by gabe.freedesktop.org (Postfix) with ESMTP id BB1F5E6443
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 12 Jun 2013 06:49:09 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130612133914.GR5004@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jun 12, 2013 at 04:39:14PM +0300, Ville Syrj=E4l=E4 wrote:
> On Wed, Jun 12, 2013 at 02:31:23PM +0100, Damien Lespiau wrote:
> > On Wed, Jun 05, 2013 at 01:34:16PM +0200, Daniel Vetter wrote:
> > > @@ -8621,6 +8657,17 @@ static void intel_cpu_pll_init(struct drm_devi=
ce *dev)
> > >  		intel_ddi_pll_init(dev);
> > >  }
> > >  =

> > > +static bool ibx_pch_dpll_get_hw_state(struct drm_i915_private *dev_p=
riv,
> > > +				      struct intel_shared_dpll *pll,
> > > +				      struct intel_dpll_hw_state *hw_state)
> > > +{
> > > +	uint32_t val;
> > > +
> > > +	val =3D I915_READ(PCH_DPLL(pll->id));
> > > +
> > > +	return val & DPLL_VCO_ENABLE;
> > > +}
> > > +
> > =

> > Don't we want !!(val & DPLL_VCO_ENABLE) here? we're comparing this to 0
> > and 1.
> =

> bool is always 0 or 1.

Oh, of course!

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

then.

-- =

Damien