From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: Kill useless "Enable panel
	fitter" comments
Date: Thu, 13 Jun 2013 18:19:39 -0700
Message-ID: <20130613181939.3e827c97@jbarnes-desktop>
References: <1371163883-638-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com
	[67.222.54.6])
	by gabe.freedesktop.org (Postfix) with SMTP id 32FB2E5DBA
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Jun 2013 18:17:54 -0700 (PDT)
In-Reply-To: <1371163883-638-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 14 Jun 2013 00:51:23 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> Now that we have this all nicely abstract into separate functions with
> self-documenting names this is pointless. And as Yuly Novikov spotted
> in the case of ilk-ivb also wrong since we use the pfit both for lvds
> and eDP
> 
> Reported-By: Yuly Novikov <ynovikov@chromium.org>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index e1184eb..2338279 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3209,7 +3209,6 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
>  		assert_fdi_rx_disabled(dev_priv, pipe);
>  	}
>  
> -	/* Enable panel fitting for LVDS */
>  	ironlake_pfit_enable(intel_crtc);
>  
>  	/*
> @@ -3315,7 +3314,6 @@ static void haswell_crtc_enable(struct drm_crtc *crtc)
>  
>  	intel_ddi_enable_pipe_clock(intel_crtc);
>  
> -	/* Enable panel fitting for eDP */
>  	ironlake_pfit_enable(intel_crtc);
>  
>  	/*
> @@ -3611,7 +3609,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)
>  	for_each_encoder_on_crtc(dev, crtc, encoder)
>  		encoder->enable(encoder);
>  
> -	/* Enable panel fitting for eDP */
>  	i9xx_pfit_enable(intel_crtc);
>  
>  	intel_crtc_load_lut(crtc);
> @@ -3649,7 +3646,6 @@ static void i9xx_crtc_enable(struct drm_crtc *crtc)
>  
>  	i9xx_enable_pll(intel_crtc);
>  
> -	/* Enable panel fitting for LVDS */
>  	i9xx_pfit_enable(intel_crtc);
>  
>  	intel_crtc_load_lut(crtc);

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center