From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: drm/i915: add i915_gem_context_get_hang_stats() Date: Wed, 19 Jun 2013 18:02:34 +0300 Message-ID: <20130619150234.GA28257@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTP id 82C9BE5F40 for ; Wed, 19 Jun 2013 08:02:47 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: mika.kuoppala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Hello Mika Kuoppala, This is a semi-automatic email about new static checker warnings. The patch c0bb617a70c9: "drm/i915: add i915_gem_context_get_hang_stats()" from Jun 12, 2013, leads to the following Smatch complaint: drivers/gpu/drm/i915/i915_gem_context.c:321 i915_gem_context_get_hang_stats() warn: variable dereferenced before check 'file' (see line 312) drivers/gpu/drm/i915/i915_gem_context.c 311 struct drm_i915_private *dev_priv = ring->dev->dev_private; 312 struct drm_i915_file_private *file_priv = file->driver_priv; ^^^^^^^^^^^^^^^^^ New dereference. 313 struct i915_hw_context *to; 314 315 if (dev_priv->hw_contexts_disabled) 316 return ERR_PTR(-ENOENT); 317 318 if (ring->id != RCS) 319 return ERR_PTR(-EINVAL); 320 321 if (file == NULL) ^^^^^^^^^^^^ New check. 322 return ERR_PTR(-EINVAL); 323 regards, dan carpenter