From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 2/6] drm/i915: Don't wait for Punit after each freq change on VLV Date: Tue, 25 Jun 2013 12:02:03 -0700 Message-ID: <20130625120203.0f334f34@jbarnes-desktop> References: <1372177266-2665-1-git-send-email-ville.syrjala@linux.intel.com> <1372177266-2665-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from oproxy14-pub.unifiedlayer.com (oproxy14-pub.unifiedlayer.com [67.222.51.224]) by gabe.freedesktop.org (Postfix) with SMTP id 40E04E613C for ; Tue, 25 Jun 2013 12:00:00 -0700 (PDT) In-Reply-To: <1372177266-2665-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyNSBKdW4gMjAxMyAxOToyMTowMiArMDMwMAp2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbSB3cm90ZToKCj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiAKPiBJdCBzZWVtcyB0aGF0IGV2ZW4gdGhvdWdoIFB1bml0IHJlcG9y dHMgdGhlIGZyZXF1ZW5jeSBjaGFuZ2UgdG8gaGF2ZQo+IGJlZW4gY29tcGxldGVkLCBpdCBzdGls bCByZXBvcnRzIHRoZSBvbGQgZnJlcXVlbmN5IGluIHRoZSBzdGF0dXMKPiByZWdpc3RlciBmb3Ig c29tZSB0aW1lLgo+IAo+IFNvIHJhdGhlciB0aGFuIHBvbGxpbmcgZm9yIFB1bml0IHRvIGNvbXBs ZXRlIHRoZSBmcmVxdWVuY3kgY2hhbmdlIGFmdGVyCj4gZWFjaCByZXF1ZXN0LCBwb2xsIGJlZm9y ZS4gVGhpcyBnZXRzIHJpZCBvZiB0aGUgc3B1cmlvdXMgIlB1bml0IG92ZXJyb2RlCj4gR1BVIGZy ZXEiIG1lc3NhZ2VzLgo+IAo+IFRoaXMgYWxzbyBsZXRzIHVzIGNvbnRpbnVlIHdvcmtpbmcgd2hp bGUgUHVuaXQgaXMgcGVyZm9ybWluZyB0aGUgYWN0dWFsCj4gZnJlcXVlbmN5IGNoYW5nZS4gQXMg YSByZXN1bHQsIG9wZW5hcmVuYSBkZW1vMDg4LXRlc3QxIHRpbWVkZW1vIGF2ZXJhZ2UKPiBmcHMg aXMgaW5jcmVhc2VkIGJ5IH41IGZwcywgYW5kIHRoZSBzbG93ZXN0IGZyYW1lIGR1cmF0aW9uIGlz IHJlZHVjZWQKPiBieSB+MjUlLgo+IAo+IFRoZSBzeXNmcyBjdXJfZnJlcSBmaWxlIGFsd2F5cyBy ZWFkcyB0aGUgY3VycmVudCBmcmVxdWVuY3kgZnJvbSBQdW5pdAo+IGFueXdheSwgc28gaGF2aW5n IHJwcy5jdXJfZGVsYXkgYmUgc2xpZ2h0bHkgb2ZmIGF0IHRpbWVzIGRvZXNuJ3QgbWF0dGVyLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCA1MyAr KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMzUgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jCj4gaW5kZXggNDhhMzE2Mi4uNmRiY2FkNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cG0uYwo+IEBAIC0zMDY2LDE3ICszMDY2LDQ5IEBAIHZvaWQgZ2VuNl9zZXRfcnBzKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsIHU4IHZhbCkKPiAgCXRyYWNlX2ludGVsX2dwdV9mcmVxX2NoYW5nZSh2 YWwgKiA1MCk7Cj4gIH0KPiAgCj4gKy8qCj4gKyAqIFdhaXQgdW50aWwgdGhlIHByZXZpb3VzIGZy ZXEgY2hhbmdlIGhhcyBjb21wbGV0ZWQsCj4gKyAqIG9yIHRoZSB0aW1lb3V0IGVsYXBzZWQsIGFu ZCB0aGVuIHVwZGF0ZSBvdXIgbm90aW9uCj4gKyAqIG9mIHRoZSBjdXJyZW50IEdQVSBmcmVxdWVu Y3kuCj4gKyAqLwo+ICtzdGF0aWMgdm9pZCB2bHZfdXBkYXRlX3Jwc19jdXJfZGVsYXkoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwl1bnNpZ25lZCBsb25nIHRpbWVv dXQgPSBqaWZmaWVzICsgbXNlY3NfdG9famlmZmllcygxMCk7Cj4gKwl1MzIgcHZhbDsKPiArCj4g KwlXQVJOX09OKCFtdXRleF9pc19sb2NrZWQoJmRldl9wcml2LT5ycHMuaHdfbG9jaykpOwo+ICsK PiArCWRvIHsKPiArCQlwdmFsID0gdmx2X3B1bml0X3JlYWQoZGV2X3ByaXYsIFBVTklUX1JFR19H UFVfRlJFUV9TVFMpOwo+ICsJCWlmICh0aW1lX2FmdGVyKGppZmZpZXMsIHRpbWVvdXQpKSB7Cj4g KwkJCURSTV9ERUJVR19EUklWRVIoInRpbWVkIG91dCB3YWl0aW5nIGZvciBQdW5pdFxuIik7Cj4g KwkJCWJyZWFrOwo+ICsJCX0KPiArCQl1ZGVsYXkoMTApOwo+ICsJfSB3aGlsZSAocHZhbCAmIDEp Owo+ICsKPiArCXB2YWwgPj49IDg7Cj4gKwo+ICsJaWYgKHB2YWwgIT0gZGV2X3ByaXYtPnJwcy5j dXJfZGVsYXkpCj4gKwkJRFJNX0RFQlVHX0RSSVZFUigiUHVuaXQgb3ZlcnJvZGUgR1BVIGZyZXE6 ICVkIE1IeiAoJXUpIHJlcXVlc3RlZCwgYnV0IGdvdCAlZCBNaHogKCV1KVxuIiwKPiArCQkJCSB2 bHZfZ3B1X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLCBkZXZfcHJpdi0+cnBzLmN1cl9kZWxheSks Cj4gKwkJCQkgZGV2X3ByaXYtPnJwcy5jdXJfZGVsYXksCj4gKwkJCQkgdmx2X2dwdV9mcmVxKGRl dl9wcml2LT5tZW1fZnJlcSwgcHZhbCksIHB2YWwpOwo+ICsKPiArCWRldl9wcml2LT5ycHMuY3Vy X2RlbGF5ID0gcHZhbDsKPiArfQo+ICsKPiAgdm9pZCB2YWxsZXl2aWV3X3NldF9ycHMoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgdTggdmFsKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IC0JdW5zaWduZWQgbG9uZyB0aW1lb3V0 ID0gamlmZmllcyArIG1zZWNzX3RvX2ppZmZpZXMoMTApOwo+ICAJdTMyIGxpbWl0cyA9IGdlbjZf cnBzX2xpbWl0cyhkZXZfcHJpdiwgJnZhbCk7Cj4gLQl1MzIgcHZhbDsKPiAgCj4gIAlXQVJOX09O KCFtdXRleF9pc19sb2NrZWQoJmRldl9wcml2LT5ycHMuaHdfbG9jaykpOwo+ICAJV0FSTl9PTih2 YWwgPiBkZXZfcHJpdi0+cnBzLm1heF9kZWxheSk7Cj4gIAlXQVJOX09OKHZhbCA8IGRldl9wcml2 LT5ycHMubWluX2RlbGF5KTsKPiAgCj4gKwl2bHZfdXBkYXRlX3Jwc19jdXJfZGVsYXkoZGV2X3By aXYpOwo+ICsKPiAgCURSTV9ERUJVR19EUklWRVIoIkdQVSBmcmVxIHJlcXVlc3QgZnJvbSAlZCBN SHogKCV1KSB0byAlZCBNSHogKCV1KVxuIiwKPiAgCQkJIHZsdl9ncHVfZnJlcShkZXZfcHJpdi0+ bWVtX2ZyZXEsCj4gIAkJCQkgICAgICBkZXZfcHJpdi0+cnBzLmN1cl9kZWxheSksCj4gQEAgLTMw ODgsMjcgKzMxMjAsMTIgQEAgdm9pZCB2YWxsZXl2aWV3X3NldF9ycHMoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgdTggdmFsKQo+ICAKPiAgCXZsdl9wdW5pdF93cml0ZShkZXZfcHJpdiwgUFVOSVRf UkVHX0dQVV9GUkVRX1JFUSwgdmFsKTsKPiAgCj4gLQlkbyB7Cj4gLQkJcHZhbCA9IHZsdl9wdW5p dF9yZWFkKGRldl9wcml2LCBQVU5JVF9SRUdfR1BVX0ZSRVFfU1RTKTsKPiAtCQlpZiAodGltZV9h ZnRlcihqaWZmaWVzLCB0aW1lb3V0KSkgewo+IC0JCQlEUk1fREVCVUdfRFJJVkVSKCJ0aW1lZCBv dXQgd2FpdGluZyBmb3IgUHVuaXRcbiIpOwo+IC0JCQlicmVhazsKPiAtCQl9Cj4gLQkJdWRlbGF5 KDEwKTsKPiAtCX0gd2hpbGUgKHB2YWwgJiAxKTsKPiAtCj4gLQlwdmFsID0gdmx2X3B1bml0X3Jl YWQoZGV2X3ByaXYsIFBVTklUX1JFR19HUFVfRlJFUV9TVFMpOwo+IC0JaWYgKChwdmFsID4+IDgp ICE9IHZhbCkKPiAtCQlEUk1fREVCVUdfRFJJVkVSKCJQdW5pdCBvdmVycm9kZSBHUFUgZnJlcTog JWQgTUh6ICgldSkgcmVxdWVzdGVkLCBidXQgZ290ICVkIE1oeiAoJXUpXG4iLAo+IC0JCQkJIHZs dl9ncHVfZnJlcShkZXZfcHJpdi0+bWVtX2ZyZXEsIHZhbCksIHZhbCwKPiAtCQkJCSB2bHZfZ3B1 X2ZyZXEoZGV2X3ByaXYtPm1lbV9mcmVxLCBwdmFsID4+IDgpLCBwdmFsID4+IDgpOwo+IC0KPiAg CS8qIE1ha2Ugc3VyZSB3ZSBjb250aW51ZSB0byBnZXQgaW50ZXJydXB0cwo+ICAJICogdW50aWwg d2UgaGl0IHRoZSBtaW5pbXVtIG9yIG1heGltdW0gZnJlcXVlbmNpZXMuCj4gIAkgKi8KPiAgCUk5 MTVfV1JJVEUoR0VONl9SUF9JTlRFUlJVUFRfTElNSVRTLCBsaW1pdHMpOwo+ICAKPiAtCWRldl9w cml2LT5ycHMuY3VyX2RlbGF5ID0gcHZhbCA+PiA4Owo+ICsJZGV2X3ByaXYtPnJwcy5jdXJfZGVs YXkgPSB2YWw7Cj4gIAo+ICAJdHJhY2VfaW50ZWxfZ3B1X2ZyZXFfY2hhbmdlKHZsdl9ncHVfZnJl cShkZXZfcHJpdi0+bWVtX2ZyZXEsIHZhbCkpOwo+ICB9CgpIaWRpbmcgc29tZSBvZiB0aGUgUHVu aXQgbGF0ZW5jeSBpcyBuaWNlLi4uCgpSZXZpZXdlZC1ieTogSmVzc2UgQmFybmVzIDxqYmFybmVz QHZpcnR1b3VzZ2Vlay5vcmc+CgoKLS0gCkplc3NlIEJhcm5lcywgSW50ZWwgT3BlbiBTb3VyY2Ug VGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK