From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Detect invalid scanout pitches Date: Tue, 25 Jun 2013 18:29:36 +0200 Message-ID: <20130625162936.GV5823@phenom.ffwll.local> References: <20130624150522.GL5004@intel.com> <1372177605-10933-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f169.google.com (mail-ea0-f169.google.com [209.85.215.169]) by gabe.freedesktop.org (Postfix) with ESMTP id C6E0CE5C31 for ; Tue, 25 Jun 2013 09:29:38 -0700 (PDT) Received: by mail-ea0-f169.google.com with SMTP id h15so7084361eak.28 for ; Tue, 25 Jun 2013 09:29:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1372177605-10933-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 25, 2013 at 05:26:45PM +0100, Chris Wilson wrote: > Report back the user error of attempting to setup a CRTC with an invalid > framebuffer pitch. This is trickier than it should be as on gen4, there > is a restriction that tiled surfaces must have a stride less than 16k - > which is less than the largest supported CRTC size. > = > v2: Fix the limits for gen3 > v3: Move check into intel_framebuffer_init() and fix VLV limits. (vsyrjal= a) > v4: Use idiomatic '>=3D' for generation checks > = > References: https://bugs.freedesktop.org/show_bug.cgi?id=3D65099 > Signed-off-by: Chris Wilson > Reviewed-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch