From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 07/24] drm/i915: fold the no-irq check into intel_hpd_irq_handler Date: Thu, 27 Jun 2013 12:39:52 +0200 Message-ID: <20130627103952.GN18285@phenom.ffwll.local> References: <1371037046-3732-1-git-send-email-daniel.vetter@ffwll.ch> <1371037046-3732-8-git-send-email-daniel.vetter@ffwll.ch> <20920.34515.539602.276112@linux-qknr.site> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id C2347E5EB1 for ; Thu, 27 Jun 2013 03:39:55 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id l10so296571eei.16 for ; Thu, 27 Jun 2013 03:39:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Egbert Eich , Egbert Eich , Intel Graphics Development , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, Jun 26, 2013 at 07:35:18PM -0300, Paulo Zanoni wrote: > 2013/6/12 Egbert Eich : > > Daniel Vetter writes: > > > The usual pattern for our sub-function irq_handlers is that they check > > > for the no-irq case themselves. This results in more streamlined code > > > in the upper irq handlers. > > > > > > Cc: Egbert Eich > > > Signed-off-by: Daniel Vetter > > > --- > > > drivers/gpu/drm/i915/i915_irq.c | 33 +++++++++++++++++---------------- > > > 1 file changed, 17 insertions(+), 16 deletions(-) > > > > > > > [reviewed code deleted] > > > > Reviewed-by: Egbert Eich > > Patches 4, 5, 6 and 7 (all reviewed by Egbert) are also Reviewed-by: > Paulo Zanoni > > But I do have to notice they don't apply anymore due to > s/hpd_status_i965/hpd_status_i915/ Yeah, I'll fix up the patches and resend the first 7 anew. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch