From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/66] drm/i915: make PDE|PTE platform specific Date: Fri, 28 Jun 2013 18:53:25 +0200 Message-ID: <20130628165325.GY18285@phenom.ffwll.local> References: <1372375867-1003-1-git-send-email-ben@bwidawsk.net> <1372375867-1003-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id ABAE2E5D70 for ; Fri, 28 Jun 2013 09:53:27 -0700 (PDT) Received: by mail-ee0-f54.google.com with SMTP id t10so1156991eei.13 for ; Fri, 28 Jun 2013 09:53:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1372375867-1003-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Thu, Jun 27, 2013 at 04:30:04PM -0700, Ben Widawsky wrote: > Nothing outside of i915_gem_gtt.c and more specifically, the relevant > gen specific init function should need to know about number of PDEs, or > PTEs per PD. Exposing this will only lead to circumventing using the > upcoming VM abstraction. > > To accomplish this, move the defines into the .c file, rename the PDE > define to be GEN6, and make the PTE count less of a magic number. > > The remaining code in the global gtt setup is a bit messy, but an > upcoming patch will clean that one up. > > v2: Don't hardcode number of PDEs (Daniel + Jesse) > Reworded commit message to reflect change. > > Reviewed-by: Jesse Barnes > Signed-off-by: Ben Widawsky First 3 patches merged to dinq, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch