From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH 3/3] drm/i915: Allow contexts to be specified for unsupported rings
Date: Sun, 30 Jun 2013 22:02:32 -0700 [thread overview]
Message-ID: <20130701050231.GA10701@bwidawsk.net> (raw)
In-Reply-To: <20130625161042.GD23824@cantiga.alporthouse.com>
On Tue, Jun 25, 2013 at 05:10:42PM +0100, Chris Wilson wrote:
> On Tue, Jun 25, 2013 at 06:47:02PM +0300, Mika Kuoppala wrote:
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > As our contexts are more general than the logical contexts supported by
> > the hardware, for instance they allow per context hangcheck tracking, it
> > is beneficial to group tasks across rings belonging to the same context.
> > Context switching is already a no-op for unsupported rings, we just
> > suffered from a little too overzealous parameter checking on entry - now
> > we just check that the context is valid.
>
> We have to drop this temporarily as the validation was being provided by
> i915_gem_context_get_hang_stats(), which is now notably absent.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
I haven't been actively reading the list recently, but I have this same
patch in the PPGTT series. I'll make sure I get it upstream in my series
if you guys are okay with dropping it here.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-07-01 4:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 15:47 [PATCH 1/3] drm/i915: Fix retrieval of hangcheck stats Mika Kuoppala
2013-06-25 15:47 ` [PATCH 2/3] drm/i915: Replace open-coding of DEFAULT_CONTEXT_ID Mika Kuoppala
2013-07-01 5:03 ` Ben Widawsky
2013-06-25 15:47 ` [PATCH 3/3] drm/i915: Allow contexts to be specified for unsupported rings Mika Kuoppala
2013-06-25 16:10 ` Chris Wilson
2013-07-01 5:02 ` Ben Widawsky [this message]
2013-07-01 5:04 ` [PATCH 1/3] drm/i915: Fix retrieval of hangcheck stats Ben Widawsky
-- strict thread matches above, loose matches on Subject: below --
2013-06-17 11:25 Chris Wilson
2013-06-17 11:25 ` [PATCH 3/3] drm/i915: Allow contexts to be specified for unsupported rings Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701050231.GA10701@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
--cc=miku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).