From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 3/3] drm/i915: Allow contexts to be specified for unsupported rings Date: Sun, 30 Jun 2013 22:02:32 -0700 Message-ID: <20130701050231.GA10701@bwidawsk.net> References: <1372175222-27622-1-git-send-email-mika.kuoppala@intel.com> <1372175222-27622-3-git-send-email-mika.kuoppala@intel.com> <20130625161042.GD23824@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A883E5C2F for ; Sun, 30 Jun 2013 21:59:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130625161042.GD23824@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Mika Kuoppala , intel-gfx@lists.freedesktop.org, miku@iki.fi List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 25, 2013 at 05:10:42PM +0100, Chris Wilson wrote: > On Tue, Jun 25, 2013 at 06:47:02PM +0300, Mika Kuoppala wrote: > > From: Chris Wilson > > > > As our contexts are more general than the logical contexts supported by > > the hardware, for instance they allow per context hangcheck tracking, it > > is beneficial to group tasks across rings belonging to the same context. > > Context switching is already a no-op for unsupported rings, we just > > suffered from a little too overzealous parameter checking on entry - now > > we just check that the context is valid. > > We have to drop this temporarily as the validation was being provided by > i915_gem_context_get_hang_stats(), which is now notably absent. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre I haven't been actively reading the list recently, but I have this same patch in the PPGTT series. I'll make sure I get it upstream in my series if you guys are okay with dropping it here. -- Ben Widawsky, Intel Open Source Technology Center