From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 42/66] drm/i915: Clean up VMAs before freeing Date: Tue, 2 Jul 2013 09:58:08 -0700 Message-ID: <20130702165807.GO4242@bwidawsk.net> References: <1372375867-1003-1-git-send-email-ben@bwidawsk.net> <1372375867-1003-43-git-send-email-ben@bwidawsk.net> <20130702105916.GM5004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 425EFE5C77 for ; Tue, 2 Jul 2013 09:58:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130702105916.GM5004@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgMDIsIDIwMTMgYXQgMDE6NTk6MTdQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgSnVuIDI3LCAyMDEzIGF0IDA0OjMwOjQzUE0gLTA3MDAsIEJlbiBX aWRhd3NreSB3cm90ZToKPiA+IEl0J3MgcXVpdGUgY29tbW9uIGZvciBhbiBvYmplY3QgdG8gc2lt cGx5IGJlIG9uIHRoZSBpbmFjdGl2ZSBsaXN0IChhbmQKPiA+IG5vdCB1bmJvdW5kKSB3aGVuIHdl IHdhbnQgdG8gZnJlZSB0aGUgY29udGV4dC4gVGhpcyBvZiBjb3Vyc2UgaGFwcGVucwo+ID4gd2l0 aCBsYXp5IHVuYmluZGluZy4gU2ltcGx5LCB0aGlzIGlzIG5lZWRlZCB3aGVuIGFuIG9iamVjdCBp c24ndCBmdWxseQo+ID4gdW5ib3VuZCBidXQgd2Ugd2FudCB0byBmcmVlIG9uZSBWTUEgb2YgdGhl IG9iamVjdCwgZm9yIHdoYXRldmVyIHJlYXNvbi4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQmVu IFdpZGF3c2t5IDxiZW5AYndpZGF3c2submV0Pgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCAgICAgICAgIHwgIDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgICAgICAgICB8IDI4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMgfCAgMSArCj4gPiAgMyBm aWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+ID4gaW5kZXggMGJjNDI1MS4uOWZlYmNkZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPiA+IEBAIC0xNjc0LDYgKzE2NzQsNyBAQCB2b2lkIGk5MTVfZ2VtX2ZyZWVfb2Jq ZWN0KHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKTsKPiA+ICBzdHJ1Y3QgaTkxNV92bWEgKmk5 MTVfZ2VtX3ZtYV9jcmVhdGUoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiA+ICAJ CQkJICAgICBzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSk7Cj4gPiAgdm9pZCBpOTE1X2dl bV92bWFfZGVzdHJveShzdHJ1Y3QgaTkxNV92bWEgKnZtYSk7Cj4gPiArdm9pZCBpOTE1X2dlbV92 bWFfY2xlYW51cChzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSk7Cj4gPiAgCj4gPiAgaW50 IF9fbXVzdF9jaGVjayBpOTE1X2dlbV9vYmplY3RfcGluKHN0cnVjdCBkcm1faTkxNV9nZW1fb2Jq ZWN0ICpvYmosCj4gPiAgCQkJCSAgICAgc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+IGluZGV4IDEyZDBlNjEuLjlhYmMzYzggMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiBAQCAtNDEzNCw2ICs0MTM0LDM0IEBAIHZv aWQgaTkxNV9nZW1fdm1hX2Rlc3Ryb3koc3RydWN0IGk5MTVfdm1hICp2bWEpCj4gPiAgCWtmcmVl KHZtYSk7Cj4gPiAgfQo+ID4gIAo+ID4gKy8qIFRoaXMgaXMgbGlrZSB1bmJpbmQoKSBidXQgd2l0 aG91dCBndHQgY29uc2lkZXJhdGlvbnMgKi8KPiA+ICt2b2lkIGk5MTVfZ2VtX3ZtYV9jbGVhbnVw KHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdm0tPmRldi0+ZGV2X3ByaXZhdGU7Cj4gPiArCXN0cnVj dCBpOTE1X3ZtYSAqdm1hLCAqbjsKPiA+ICsKPiA+ICsJQlVHX09OKGlzX2k5MTVfZ2d0dCh2bSkp Owo+ID4gKwlXQVJOX09OKCFsaXN0X2VtcHR5KCZ2bS0+YWN0aXZlX2xpc3QpKTsKPiA+ICsKPiA+ ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHZtYSwgbiwgJnZtLT52bWFfbGlzdCwgcGVyX3Zt X2xpbmspIHsKPiA+ICsJCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmogPSB2bWEtPm9i ajsKPiA+ICsKPiA+ICsJCWlmIChXQVJOX09OKCFpOTE1X2dlbV9vYmpfYm91bmQob2JqLCB2bSkp KQo+ID4gKwkJCWNvbnRpbnVlOwo+ID4gKwo+ID4gKwkJaTkxNV9nZW1fb2JqZWN0X3VucGluX3Bh Z2VzKG9iaik7Cj4gPiArCj4gPiArCQlsaXN0X2RlbCgmdm1hLT5tbV9saXN0KTsKPiA+ICsJCWxp c3RfZGVsKCZ2bWEtPnZtYV9saW5rKTsKPiA+ICsJCWRybV9tbV9yZW1vdmVfbm9kZSgmdm1hLT5u b2RlKTsKPiA+ICsJCWk5MTVfZ2VtX3ZtYV9kZXN0cm95KHZtYSk7Cj4gCj4gSXMgdGhlcmUgYSBn b29kIHJlYXNvbiB3aHkgYWxsIG9mIHRoYXQgc3R1ZmYgaXNuJ3QgaW5jbHVkZWQgaW4KPiBpOTE1 X2dlbV92bWFfZGVzdHJveSgpPyBJdCBzZWVtcyBsaWtlIGl0IHNob3VsZCBiZSB0aGVyZS4KCk5v IGdvb2QgcmVhc29uLCBqdXN0IHNsb3BweS4gVGhlIHJlbW92ZSBub2RlIGlkZWFsbHkgc2hvdWxk IG9ubHkgaGFwcGVuCmNvbmRpdGlvbmFsbHkgKGllLiBhdCB1bmJpbmQpLCBidXQgdGhlIGxpc3Rf ZGVsIHN0dWZmIHNob3VsZCBnbyBpbgpkZXN0cm95LgoKPiAKPiA+ICsKPiA+ICsJCWlmIChsaXN0 X2VtcHR5KCZvYmotPnZtYV9saXN0KSkKPiA+ICsJCQlsaXN0X21vdmVfdGFpbCgmb2JqLT5nbG9i YWxfbGlzdCwKPiA+ICsJCQkJICAgICAgICZkZXZfcHJpdi0+bW0udW5ib3VuZF9saXN0KTsKPiA+ ICsJfQo+ID4gK30KPiA+ICsKPiA+ICBpbnQKPiA+ICBpOTE1X2dlbV9pZGxlKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpCj4gPiAgewo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2NvbnRleHQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRl eHQuYwo+ID4gaW5kZXggOTg4MTIzZi4uYzQ1Y2Q1YyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gPiBAQCAtMTI5LDYgKzEyOSw3IEBAIHZvaWQgaTkx NV9nZW1fY29udGV4dF9mcmVlKHN0cnVjdCBrcmVmICpjdHhfcmVmKQo+ID4gIAlzdHJ1Y3QgaTkx NV9od19jb250ZXh0ICpjdHggPSBjb250YWluZXJfb2YoY3R4X3JlZiwKPiA+ICAJCQkJCQkgICB0 eXBlb2YoKmN0eCksIHJlZik7Cj4gPiAgCj4gPiArCWk5MTVfZ2VtX3ZtYV9jbGVhbnVwKCZjdHgt PnBwZ3R0LmJhc2UpOwo+ID4gIAlpZiAoY3R4LT5wcGd0dC5jbGVhbnVwKQo+ID4gIAkJY3R4LT5w cGd0dC5jbGVhbnVwKCZjdHgtPnBwZ3R0KTsKPiA+ICAJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVu Y2UoJmN0eC0+b2JqLT5iYXNlKTsKPiA+IC0tIAo+ID4gMS44LjMuMQo+ID4gCj4gPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0t IAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsIE9UQwoKLS0gCkJlbiBXaWRhd3NreSwgSW50ZWwg T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK