From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 7/7] drm/i915: add i915_get_reset_stats_ioctl Date: Wed, 3 Jul 2013 14:23:23 -0700 Message-ID: <20130703212323.GC5488@bwidawsk.net> References: <1372861332-6308-1-git-send-email-mika.kuoppala@intel.com> <1372861332-6308-8-git-send-email-mika.kuoppala@intel.com> <20130703151431.GB19383@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 34C39E5FD4 for ; Wed, 3 Jul 2013 14:23:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130703151431.GB19383@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Mika Kuoppala , intel-gfx@lists.freedesktop.org, Ian Romanick , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 03, 2013 at 04:14:31PM +0100, Chris Wilson wrote: > On Wed, Jul 03, 2013 at 05:22:12PM +0300, Mika Kuoppala wrote: > > int i915_max_ioctl = DRM_ARRAY_SIZE(i915_ioctls); > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > > index 33cb973..0d4e3a8 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -1350,3 +1350,37 @@ int i915_reg_read_ioctl(struct drm_device *dev, > > > > return 0; > > } > > + > > +int i915_get_reset_stats_ioctl(struct drm_device *dev, > > + void *data, struct drm_file *file) > > +{ > > + struct drm_i915_private *dev_priv = dev->dev_private; > > + struct drm_i915_reset_stats *args = data; > > + struct i915_ctx_hang_stats *hs; > > + int ret; > > + > > + if (args->ctx_id == 0 && !capable(CAP_SYS_ADMIN)) > > + return -EPERM; > > When per-file default contexts land, there will not be any global > information leak and so we can drop the capability check here. > > Ben, will we be informing userspace about the ABI change? > -Chris Hmm. I'm not convinced we ever want to reset the default context stats. > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center