From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 7/7] drm/i915: add i915_get_reset_stats_ioctl Date: Thu, 4 Jul 2013 10:54:58 +0300 Message-ID: <20130704075458.GT5004@intel.com> References: <1372861332-6308-1-git-send-email-mika.kuoppala@intel.com> <1372861332-6308-8-git-send-email-mika.kuoppala@intel.com> <20130703151431.GB19383@cantiga.alporthouse.com> <20130703212323.GC5488@bwidawsk.net> <20130703214111.GF19383@cantiga.alporthouse.com> <20130703214415.GD5488@bwidawsk.net> <20130703220039.GF5488@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id BB697E665B for ; Thu, 4 Jul 2013 00:55:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130703220039.GF5488@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 03, 2013 at 03:00:39PM -0700, Ben Widawsky wrote: > On Wed, Jul 03, 2013 at 11:58:31PM +0200, Daniel Vetter wrote: > > On Wed, Jul 3, 2013 at 11:44 PM, Ben Widawsky wrote: > > > Yes. It won't be a requirement for mesa to know, but since I want to > > > kill aliasing ppgtt as much as possible, I intend to update getparam = to > > > both set 0 to aliasing, and a new one for ppgtt. > > = > > We use that one essentially to decide whether the hw uses ppgtt or > > not, aliasing kinda doesn't matter. So to keep api I guess we need to > > keep that one enabled. Although only i-g-t really cares I think, but > > keeping it working would still be nice. Maybe just add a comment to > > the #define explaining what's going on? > > -Daniel > = > It's a bit off topic for this series, but I don't see any reason to keep > it working. If it doesn't end up being too much trouble, I can - but in > actuality on the kernel would be able to use it. Exposing the param as > true to user space would be a lie. But won't old Mesa refuse to work if you tell it aliasing ppgtt is not enabled? -- = Ville Syrj=E4l=E4 Intel OTC