From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 00/30] drm/i915: Lots of workaround changes Date: Fri, 5 Jul 2013 12:51:54 -0700 Message-ID: <20130705195154.GB3716@bwidawsk.net> References: <1373032128-23755-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id C7DDFE5C7A for ; Fri, 5 Jul 2013 12:48:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1373032128-23755-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 05, 2013 at 04:48:18PM +0300, ville.syrjala@linux.intel.com wrote: > I was going over the workaround database with VLV mainly in mind, but I > ended up stumbling on quite a few others as well. > > This series adds the workarounds names in a bunch of places where we > missed them, adds a few workarounds we seem to have missed, drops some > that were never supposed to be there, and drops quite a few pre-production > workarounds. > > I'm not sure we want to drop some of the VLV workarounds quite yet. I know > Jani will hate me when he comes back from vacation since his current machine > would be affected. > > I've run these on my VLV and IVB machines, and didn't spot any problems. > The SNB and HSW ones I've not actually tested. I have a sneaking suspicion at least a few of these will blow up once their in the wild. You're trusting the docs an awful lot. At least the patches seem quite bisectable though, so that's a saving grace. One thing which might be interesting/compelling is some performance data (especially around places where you've removed unneeded workarounds). > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center