From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 00/30] drm/i915: Lots of workaround changes Date: Fri, 5 Jul 2013 22:13:30 +0200 Message-ID: <20130705201330.GY18285@phenom.ffwll.local> References: <1373032128-23755-1-git-send-email-ville.syrjala@linux.intel.com> <20130705195154.GB3716@bwidawsk.net> <20130705200248.GN5004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CE1FE5F75 for ; Fri, 5 Jul 2013 13:13:32 -0700 (PDT) Received: by mail-ee0-f42.google.com with SMTP id c4so1588058eek.29 for ; Fri, 05 Jul 2013 13:13:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130705200248.GN5004@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 05, 2013 at 11:02:48PM +0300, Ville Syrj=E4l=E4 wrote: > On Fri, Jul 05, 2013 at 12:51:54PM -0700, Ben Widawsky wrote: > > On Fri, Jul 05, 2013 at 04:48:18PM +0300, ville.syrjala@linux.intel.com= wrote: > > > I was going over the workaround database with VLV mainly in mind, but= I > > > ended up stumbling on quite a few others as well. > > > = > > > This series adds the workarounds names in a bunch of places where we > > > missed them, adds a few workarounds we seem to have missed, drops some > > > that were never supposed to be there, and drops quite a few pre-produ= ction > > > workarounds. > > > = > > > I'm not sure we want to drop some of the VLV workarounds quite yet. I= know > > > Jani will hate me when he comes back from vacation since his current = machine > > > would be affected. > > > = > > > I've run these on my VLV and IVB machines, and didn't spot any proble= ms. > > > The SNB and HSW ones I've not actually tested. > > = > > I have a sneaking suspicion at least a few of these will blow up once > > their in the wild. You're trusting the docs an awful lot. At least the > > patches seem quite bisectable though, so that's a saving grace. > = > Yeah I wanted to keep them as isolated as possible just for that reason. > = > > One thing which might be interesting/compelling is some performance data > > (especially around places where you've removed unneeded workarounds). > = > Some power consumption numbers migth be nice, since quite a few are > clock gating related. > = > There are plenty of options to deal with the risk: > - Throw the patches away and pretend they never existed > - Merge them all and watch out for fireworks > - Drop a few of them into every kernel release to avoid too > many regressions at once. I guess it'll take a few years > get through the list this way. Imo review them again, drop them into dinq, see what happens. If they blow up we can yell at the Bsepc or w/a guys ;-) -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch