From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: fix up ring cleanup for the i830/i845 CS tlb w/a Date: Sat, 6 Jul 2013 01:15:55 +0200 Message-ID: <20130705231555.GD18285@phenom.ffwll.local> References: <1373060390-1109-1-git-send-email-daniel.vetter@ffwll.ch> <20130705225341.GB13441@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130705225341.GB13441@cantiga.alporthouse.com> Sender: stable-owner@vger.kernel.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 05, 2013 at 11:53:41PM +0100, Chris Wilson wrote: > On Fri, Jul 05, 2013 at 11:39:50PM +0200, Daniel Vetter wrote: > > It's not a good idea to also run the pipe_control cleanup. > > > > This regression has been introduced whith the original cs tlb w/a in > > > > commit b45305fce5bb1abec263fcff9d81ebecd6306ede > > Author: Daniel Vetter > > Date: Mon Dec 17 16:21:27 2012 +0100 > > > > drm/i915: Implement workaround for broken CS tlb on i830/845 > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64610 > > Cc: Chris Wilson > > Cc: stable@vger.kernel.org > > Signed-off-by: Daniel Vetter > > Just promise me on the next ring->private, we will add a real > destructor. > Reviewed-by: Chris Wilson Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch