From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] intel_get_llc_size: Small tool to query LLC size Date: Wed, 10 Jul 2013 08:34:18 +0200 Message-ID: <20130710063418.GH18285@phenom.ffwll.local> References: <1373425083-1276-1-git-send-email-ben@bwidawsk.net> <1373425083-1276-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 323C4E5DB7 for ; Tue, 9 Jul 2013 23:34:17 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id j14so4621933eak.8 for ; Tue, 09 Jul 2013 23:34:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1373425083-1276-2-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Bryan Bell List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 09, 2013 at 07:58:03PM -0700, Ben Widawsky wrote: > CC: Chad Versace > CC: Bryan Bell > Signed-off-by: Ben Widawsky So I think we should run this from igt and check its return value. And since we've had a few bugs with other (currently untested) igt tools, can you please add a new igt_tools testcase which just runs those? I'm thinking of intel_reg_dumper and intel_reg_read (with some render ring register that exists everywhere) on top of running intel_get_llc_size here. And please also add eLLC size querying. -Daniel > --- > tools/Makefile.am | 1 + > tools/intel_get_llc_size.c | 57 ++++++++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 58 insertions(+) > create mode 100644 tools/intel_get_llc_size.c > = > diff --git a/tools/Makefile.am b/tools/Makefile.am > index 2519169..a064b65 100644 > --- a/tools/Makefile.am > +++ b/tools/Makefile.am > @@ -9,6 +9,7 @@ bin_PROGRAMS =3D \ > intel_bios_dumper \ > intel_bios_reader \ > intel_error_decode \ > + intel_get_llc_size \ > intel_gpu_top \ > intel_gpu_time \ > intel_gtt \ > diff --git a/tools/intel_get_llc_size.c b/tools/intel_get_llc_size.c > new file mode 100644 > index 0000000..bd384d2 > --- /dev/null > +++ b/tools/intel_get_llc_size.c > @@ -0,0 +1,57 @@ > +/* > + * Copyright =A9 2013 Intel Corporation > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a > + * copy of this software and associated documentation files (the "Softwa= re"), > + * to deal in the Software without restriction, including without limita= tion > + * the rights to use, copy, modify, merge, publish, distribute, sublicen= se, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice (including the = next > + * paragraph) shall be included in all copies or substantial portions of= the > + * Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI= TY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SH= ALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR = OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISI= NG > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + * > + */ > + > +#include > +#include "drmtest.h" > +#include "i915_drm.h" > + > +static int get_llc_size(int fd) > +{ > + struct drm_i915_getparam gp; > + int size; > + > + gp.param =3D I915_PARAM_HAS_LLC; > + gp.value =3D &size; > + > + if (ioctl(fd, DRM_IOCTL_I915_GETPARAM, &gp, sizeof(gp))) > + return 0; > + > + return size; > +} > + > +int main(int argc, char **argv) > +{ > + int size, fd =3D drm_open_any(); > + > + size =3D get_llc_size(fd); > + > + if (size =3D=3D 0) > + fprintf(stdout, "Doesn't have LLC\n"); > + else if (size =3D=3D 1) > + fprintf(stdout, "Kernel is too old to determine LLC size\n"); > + else > + fprintf(stdout, "LLC size =3D %dK\n", size>>10); > + > + return 0; > +} > -- = > 1.8.3.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch