From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] drm/i915: Skip pixel multiplier x-check if
 we fail to send the command
Date: Thu, 11 Jul 2013 21:35:17 +0100
Message-ID: <20130711203517.GF20291@strange.amr.corp.intel.com>
References: <1373568360-12566-1-git-send-email-damien.lespiau@intel.com>
	<20130711195233.GX6143@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 89054E5CFB
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 11 Jul 2013 13:36:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130711195233.GX6143@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jul 11, 2013 at 09:52:33PM +0200, Daniel Vetter wrote:
> On Thu, Jul 11, 2013 at 07:46:00PM +0100, Damien Lespiau wrote:
> > If intel_sdvo_get_value() fails here, val is unitialized and the cross
> > check won't check anything.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_sdvo.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> > index b8e1623..4481f6a 100644
> > --- a/drivers/gpu/drm/i915/intel_sdvo.c
> > +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> > @@ -1357,7 +1357,10 @@ static void intel_sdvo_get_config(struct intel_encoder *encoder,
> >  	}
> >  
> >  	/* Cross check the port pixel multiplier with the sdvo encoder state. */
> > -	intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_CLOCK_RATE_MULT, &val, 1);
> > +	if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_CLOCK_RATE_MULT,
> > +				  &val, 1))
> > +		return;
> 
> But now it fails silently instead of being paranoid ... Can we just shut
> up the tool instead?

We absolutely can! (and it's done).

-- 
Damien