From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file Date: Fri, 12 Jul 2013 10:56:55 -0700 Message-ID: <20130712175655.GE15384@bwidawsk.net> References: <1373648907-28774-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 75886E5EF8 for ; Fri, 12 Jul 2013 10:57:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1373648907-28774-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 12, 2013 at 06:08:22PM +0100, Chris Wilson wrote: > Currently, the register access code is split between i915_drv.c and > intel_pm.c. It only bares a superficial resemblance to the reset of the > powermanagement code, so move it all into its own file. This is to ease > further patches to enforce serialised register access. > > v2: Scan for random abuse of I915_WRITE_NOTRACE > v3: Take the opportunity to rename the GT functions as uncore. Uncore is > the term used by the hardware design (and bspec) for all functions > outside of the GPU (and CPU) cores in what is also known as the System > Agent. > Bikesheds: Would have preferred the gt/pm_init split as a separate patch. intel_uncore_clear_errors/chec_errors seems silly to me. Acked-by: Ben Widawsky > > Signed-off-by: Chris Wilson > [snip] -- Ben Widawsky, Intel Open Source Technology Center