From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 6/6] drm/i915: Convert the register access tracepoint to be conditional Date: Sun, 14 Jul 2013 13:28:11 -0700 Message-ID: <20130714202810.GD24025@bwidawsk.net> References: <1373648907-28774-1-git-send-email-chris@chris-wilson.co.uk> <1373648907-28774-6-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id A3217E5BFB for ; Sun, 14 Jul 2013 13:24:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1373648907-28774-6-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 12, 2013 at 06:08:27PM +0100, Chris Wilson wrote: > The TRACE_EVENT_CONDITION is supposed to generate more efficient code > than if (cond) trace(), which is what we are currently using inside the > register access functions. > > v2: Rebase onto uncore > > Signed-off-by: Chris Wilson One thing I've thought about this is a trace_on_once, or trace_on_poll would be cool for polled reads. Obviously we can post-process it, but we always risk losing events if we fill up too much of the ringbuffer with stuff we don't care about. In any case, I very much like the condition added to the trace itself, and reading probably the same docs as you agree it should be faster. Looking over our code. It looks like I missed trace events when writing the PTEs in i915_gem_gtt.c. Can you get around to fixing those up? [snip] -- Ben Widawsky, Intel Open Source Technology Center