From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 3.5/5] drm/i915: Do eLLC detection earlier Date: Sun, 14 Jul 2013 13:37:02 -0700 Message-ID: <20130714203702.GC30966@bwidawsk.net> References: <1372960927-1112-3-git-send-email-ben@bwidawsk.net> <1372963366-526-1-git-send-email-ben@bwidawsk.net> <20130713093944.GN6143@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 41790E5BFB for ; Sun, 14 Jul 2013 13:33:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130713093944.GN6143@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sat, Jul 13, 2013 at 11:39:44AM +0200, Daniel Vetter wrote: > On Thu, Jul 04, 2013 at 11:42:46AM -0700, Ben Widawsky wrote: > > We need it before we set the pte_encode function pointers, which happens > > really early, in gtt_init. > > > > The problem with just doing the normal sequence earlier is we don't have > > the ability to use forcewake until after the pte functions have been set > > up. > > > > Since all solutions are somewhat ugly (barring rewriting all the init > > ordering), I've opted to do the detection really early, and the enabling > > later - since the register to detect doesn't require forcewake. > > > > Signed-off-by: Ben Widawsky > > Looking at patch 3.5 here and patch 3 I think those should be squashed > together. Ok if I do that when applying? > -Daniel Of course. [snip] -- Ben Widawsky, Intel Open Source Technology Center