From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 08/11] drm/intel: add enable_psr module
 option and disable psr by default
Date: Mon, 15 Jul 2013 23:01:13 +0100
Message-ID: <20130715220113.GG2823@cantiga.alporthouse.com>
References: <1373579105-1732-1-git-send-email-rodrigo.vivi@gmail.com>
	<1373579105-1732-9-git-send-email-rodrigo.vivi@gmail.com>
	<20130715140149.GD2823@cantiga.alporthouse.com>
	<CABVU7+uvtGvMJzrLvFG-dHbzwgCqLc-DfAB4bap+VXB=ag54yg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (s16502780.onlinehome-server.info
	[87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id 21A36E5F80
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 15 Jul 2013 15:01:18 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CABVU7+uvtGvMJzrLvFG-dHbzwgCqLc-DfAB4bap+VXB=ag54yg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jul 15, 2013 at 05:23:35PM -0300, Rodrigo Vivi wrote:
> On Mon, Jul 15, 2013 at 11:01 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Thu, Jul 11, 2013 at 06:45:02PM -0300, Rodrigo Vivi wrote:
> >> v2: prefer seq_puts to seq_printf detected by Paulo Zanoni.
> >> v3: PSR is disabled by default. Without userspace ready it
> >>     will cause regression for kde and xdm users
> >
> > I think we should still aim to enable by default and disable on the
> > first direct access after a mmioflip.
> 
> unfortunately I couldn't implement a reliable way of detect it without
> false positives,

Can you give me an example of one of the false positives? The detect
front buffer writes patches we had should be good enough to only punish
legacy userspace.

> so let's put this disabled for now and revert when I find a reliable way.

That's fine, just think we're giving up too easily ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre