From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 08/11] drm/intel: add enable_psr module
 option and disable psr by default
Date: Tue, 16 Jul 2013 07:19:11 +0200
Message-ID: <20130716051911.GE5784@phenom.ffwll.local>
References: <1373579105-1732-1-git-send-email-rodrigo.vivi@gmail.com>
	<1373579105-1732-9-git-send-email-rodrigo.vivi@gmail.com>
	<20130715140149.GD2823@cantiga.alporthouse.com>
	<CABVU7+uvtGvMJzrLvFG-dHbzwgCqLc-DfAB4bap+VXB=ag54yg@mail.gmail.com>
	<20130715220113.GG2823@cantiga.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47])
	by gabe.freedesktop.org (Postfix) with ESMTP id A5B88E5D01
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 15 Jul 2013 22:19:10 -0700 (PDT)
Received: by mail-ee0-f47.google.com with SMTP id e49so103032eek.34
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 15 Jul 2013 22:19:09 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130715220113.GG2823@cantiga.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Rodrigo Vivi <rodrigo.vivi@gmail.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jul 15, 2013 at 11:01:13PM +0100, Chris Wilson wrote:
> On Mon, Jul 15, 2013 at 05:23:35PM -0300, Rodrigo Vivi wrote:
> > On Mon, Jul 15, 2013 at 11:01 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > On Thu, Jul 11, 2013 at 06:45:02PM -0300, Rodrigo Vivi wrote:
> > >> v2: prefer seq_puts to seq_printf detected by Paulo Zanoni.
> > >> v3: PSR is disabled by default. Without userspace ready it
> > >>     will cause regression for kde and xdm users
> > >
> > > I think we should still aim to enable by default and disable on the
> > > first direct access after a mmioflip.
> > 
> > unfortunately I couldn't implement a reliable way of detect it without
> > false positives,
> 
> Can you give me an example of one of the false positives? The detect
> front buffer writes patches we had should be good enough to only punish
> legacy userspace.
> 
> > so let's put this disabled for now and revert when I find a reliable way.
> 
> That's fine, just think we're giving up too easily ;-)

Agreed, and part of the problem is that slacker-me is sitting on a big
review of your rfc patches ;-) I really need to get around to write that
down into a nice mail from my ineligible notes ...

I hope that with good sw side frontbuffer rendering tracking we'll be able
to enable psr in more conditions, e.g. also when sprites are enabled and
similar cases.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch