From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH libdrm] intel: silence valgrind warnings for unsynchronized maps Date: Tue, 16 Jul 2013 15:24:29 +0200 Message-ID: <20130716132429.GV5784@phenom.ffwll.local> References: <1373424599-8583-1-git-send-email-olvaffe@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com [209.85.215.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 73BBCE6C2B for ; Tue, 16 Jul 2013 06:24:28 -0700 (PDT) Received: by mail-ea0-f179.google.com with SMTP id b15so383049eae.10 for ; Tue, 16 Jul 2013 06:24:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1373424599-8583-1-git-send-email-olvaffe@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chia-I Wu Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 10, 2013 at 10:49:59AM +0800, Chia-I Wu wrote: > Mark the address ranges as accessible with VALGRIND_MAKE_MEM_DEFINED. > > Signed-off-by: Chia-I Wu lgtm. Applied to mater, thanks for the patch. -Daniel > --- > intel/intel_bufmgr_gem.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c > index a51e3f3..f98f7a7 100644 > --- a/intel/intel_bufmgr_gem.c > +++ b/intel/intel_bufmgr_gem.c > @@ -1322,6 +1322,7 @@ int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo) > int drm_intel_gem_bo_map_unsynchronized(drm_intel_bo *bo) > { > drm_intel_bufmgr_gem *bufmgr_gem = (drm_intel_bufmgr_gem *) bo->bufmgr; > + drm_intel_bo_gem *bo_gem = (drm_intel_bo_gem *) bo; > int ret; > > /* If the CPU cache isn't coherent with the GTT, then use a > @@ -1335,7 +1336,13 @@ int drm_intel_gem_bo_map_unsynchronized(drm_intel_bo *bo) > return drm_intel_gem_bo_map_gtt(bo); > > pthread_mutex_lock(&bufmgr_gem->lock); > + > ret = map_gtt(bo); > + if (ret == 0) { > + drm_intel_gem_bo_mark_mmaps_incoherent(bo); > + VG(VALGRIND_MAKE_MEM_DEFINED(bo_gem->gtt_virtual, bo->size)); > + } > + > pthread_mutex_unlock(&bufmgr_gem->lock); > > return ret; > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch