From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED. Date: Wed, 17 Jul 2013 21:18:18 +0100 Message-ID: <20130717201818.GH5249@cantiga.alporthouse.com> References: <1373579105-1732-1-git-send-email-rodrigo.vivi@gmail.com> <1373579105-1732-10-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (s16502780.onlinehome-server.info [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D0DEE5D26 for ; Wed, 17 Jul 2013 13:18:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: > Hi Chris, > > could you please review this specific one or give you ack here? Didn't see anything wrong with it. The only caveat I have is that the GETPARAM must be accurate immediately following a setcrtc. If you can guarrantee that is true, you can have my Reviewed-by: Chris Wilson and if Daniel delays, ask him to reserve the PARAM number. -Chris -- Chris Wilson, Intel Open Source Technology Centre