From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 09/11] drm/i915: Adding global I915_PARAM
 for PSR ENABLED.
Date: Thu, 18 Jul 2013 10:24:21 +0200
Message-ID: <20130718082421.GL4550@phenom.ffwll.local>
References: <1373579105-1732-1-git-send-email-rodrigo.vivi@gmail.com>
	<1373579105-1732-10-git-send-email-rodrigo.vivi@gmail.com>
	<CABVU7+ujKYhps=pd4mck_MsO-PVkJY9mqJBOMY-96Yf=fhoA1w@mail.gmail.com>
	<20130717201818.GH5249@cantiga.alporthouse.com>
	<CABVU7+vHJ88UV3HhEa0tYjNEdOY-jmw2kmk42uCKtvoJdGCZUg@mail.gmail.com>
	<20130717210834.GJ5249@cantiga.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f182.google.com (mail-ea0-f182.google.com
	[209.85.215.182])
	by gabe.freedesktop.org (Postfix) with ESMTP id 226EAE6791
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 18 Jul 2013 01:24:20 -0700 (PDT)
Received: by mail-ea0-f182.google.com with SMTP id d10so1553112eaj.41
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 18 Jul 2013 01:24:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130717210834.GJ5249@cantiga.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Rodrigo Vivi <rodrigo.vivi@gmail.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jul 17, 2013 at 10:08:34PM +0100, Chris Wilson wrote:
> On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote:
> > On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote:
> > >> Hi Chris,
> > >>
> > >> could you please review this specific one or give you ack here?
> > >
> > > Didn't see anything wrong with it. The only caveat I have is that the
> > > GETPARAM must be accurate immediately following a setcrtc.
> > 
> > To be truly honest I have no idea, mainly when we alternate with fbcon
> > updating psr state at set_base.
> > Could you please also review subsequent patches in this series... 10 and 11.
> > I think 11 answer this question...
> 
> If it is not clear by this point, and the changelog doesn't make it
> clear, then something is missing from this patch. Hint ;-)

I'll punt on userspace interface changes, at least until we've figured out
a clear picture how to do this.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch