From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 00/12] Completion of i915 VMAs Date: Mon, 22 Jul 2013 09:35:06 -0700 Message-ID: <20130722163506.GA6637@bwidawsk.net> References: <1374458899-8635-1-git-send-email-ben@bwidawsk.net> <20130722104240.GA22888@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id C4B44E6151 for ; Mon, 22 Jul 2013 09:35:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130722104240.GA22888@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Mon, Jul 22, 2013 at 11:42:40AM +0100, Chris Wilson wrote: > On Sun, Jul 21, 2013 at 07:08:07PM -0700, Ben Widawsky wrote: > > Map, and unmap are logical functionalities to add for an address space. > > They do more or less what you'd think: take an object and create a > > mapping via the GPU's page tables to that object. Of course, without the > > rest of the patches from [3], there will only ever be 1 address space, > > with the weird aliasing ppgtt behind it. One thing which I toyed with, > > but opted not to include was to directly pass obj,vm to map/unmap > > instead of doing the slightly less pretty way as I've done in execbuf > > and bind. In the future I think I may just do this, but for now it's not > > a big win as the end result wasn't much better (and I didn't get it to > > immediately work). > > That's annoying. Currently we use map to refer to the process of making > a CPU mapping to the objects and bind for doing it from the GPU's > perspective. And since the CPU map may well require a GPU map, keeping > the nomenclature distinct helps easily confused me. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre I can rename it, I expect you will review it. -- Ben Widawsky, Intel Open Source Technology Center