From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] x86: add early quirk for reserving
 Intel graphics stolen memory v3
Date: Thu, 25 Jul 2013 10:36:33 +0200
Message-ID: <20130725083633.GF5939@phenom.ffwll.local>
References: <1374710683-2614-1-git-send-email-jbarnes@virtuousgeek.org>
	<1374710683-2614-2-git-send-email-jbarnes@virtuousgeek.org>
	<20130725074149.GD5939@phenom.ffwll.local>
	<20130725083405.GA5134@cantiga.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f169.google.com (mail-ea0-f169.google.com
	[209.85.215.169])
	by gabe.freedesktop.org (Postfix) with ESMTP id C12A4E5FEC
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 25 Jul 2013 01:36:35 -0700 (PDT)
Received: by mail-ea0-f169.google.com with SMTP id h15so768323eak.0
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 25 Jul 2013 01:36:34 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130725083405.GA5134@cantiga.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel@ffwll.ch>, Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jul 25, 2013 at 09:34:05AM +0100, Chris Wilson wrote:
> On Thu, Jul 25, 2013 at 09:41:49AM +0200, Daniel Vetter wrote:
> > On Wed, Jul 24, 2013 at 05:04:43PM -0700, Jesse Barnes wrote:
> > Two bikesheds:
> > - Can't we give the thing a better name like "Intel Graphics Stolen"?
> 
> Using a custom type and name seems simple enough and naturally leads it
> to ending up in iomem_resource.
> 
> > - Can't we store the iomem region somewhere so that intel-gtt.ko and
> >   i915.ko can get at it and we could drop the duplicated stolen detection
> >   code?
> 
> The choice is then walking the resource list looking for our named
> region or reading a couple of registers. Certainly walking the iomem makes
> everything much clearer.

Oh, I like this ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch