From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/i915: Sync the hotplug work when device suspending Date: Mon, 5 Aug 2013 07:42:21 +0200 Message-ID: <20130805054221.GK22035@phenom.ffwll.local> References: <1374946982.28551.4.camel@cliu38-desktop-build> <20130727094014.GC3132@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130727094014.GC3132@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Chuansheng Liu , daniel.vetter@ffwll.ch, airlied@linux.ie, intel-gfx@lists.freedesktop.org, fei.li@intel.com, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Jul 27, 2013 at 10:40:14AM +0100, Chris Wilson wrote: > On Sun, Jul 28, 2013 at 01:43:02AM +0800, Chuansheng Liu wrote: > > > > It is possible that during i915 device suspending with one pending > > hotplug work, one of cases is the device resume/suspend quickly. > > > > At this case, the hotplug work will be executed even after device > > is OFF, in Intel Android platform, it will cause system hang. > > See > > 1343070574-23917-1-git-send-email-chris@chris-wilson.co.uk > http://lists.freedesktop.org/archives/intel-gfx/2012-July/019144.html > > which is in response to the bug raised here > > s5hlilr4s9h.wl%tiwai@suse.de > http://lists.freedesktop.org/archives/intel-gfx/2012-April/016738.html Oops, I fail. And since your patch also has the required flush_scheduled_work (this will annoy Jesse since we flush system-wide, but alas) and is older ... can you please resubmit with References: for this new thread and the above two added and Chuanshen Lui cc'ed? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch