From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 5/8] drm/i915: avoid waking up from PC8 on
 GMBUS operations
Date: Mon, 5 Aug 2013 08:07:29 +0200
Message-ID: <20130805060729.GM22035@phenom.ffwll.local>
References: <1375130907-4054-1-git-send-email-przanoni@gmail.com>
	<1375130907-4054-6-git-send-email-przanoni@gmail.com>
	<20130730093041.GB1310@cantiga.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
	[74.125.82.175])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2D7A9E5BF9
	for <intel-gfx@lists.freedesktop.org>;
	Sun,  4 Aug 2013 23:07:23 -0700 (PDT)
Received: by mail-we0-f175.google.com with SMTP id q58so2084957wes.20
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 04 Aug 2013 23:07:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130730093041.GB1310@cantiga.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Paulo Zanoni <przanoni@gmail.com>, intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jul 30, 2013 at 10:30:41AM +0100, Chris Wilson wrote:
> On Mon, Jul 29, 2013 at 05:48:24PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > 
> > If we're already allowing PC8, just don't use the IRQs, so we won't
> > need to wake from PC8. Waking up from PC8 is a slow thing, so avoid it
> > when we can.
> 
> You would also need to explain that the GMBUS is outside of the display
> power well.
> 
> Looks reasonable, the only bit is moving the read of forbid_count into
> hsw_pc8_enabled() so that the gmbus code isn't poking around with
> someone else's locks, and we can safely do an unlocked optimistic read
> here.

IIrc EDID reads with interrupts take 22ms, without them they can easily
take 100ms. Is pc8+ exit indeed longer than that difference?

If the issue is that we flip-flop between pc8+ allow/deny too often then
we could just add a slight delay.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch