Re: [PATCH 6/8] drm/i915/hmdi: Rename set_infoframe() to write_infoframe()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote:
> set_frame() wraps the write_frame() vfunc. Be consistent and name the
> wrapping function like the vfunc being called.
> 
> It's doubly confusing as we also have a set_infoframes() vfunc and
> set_infoframe() doesn't wrap it.

I guess the logic was 
 set_infoframes -> set_<type>_infoframe -> set_infoframe -> write_infoframe

But I don't really have an opinion on which is better, so:

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 57dd413..8424882 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -355,8 +355,8 @@ static void hsw_write_infoframe(struct drm_encoder *encoder,
>  #define DIP_BUFFER_SIZE	\
>  	(max(INFOFRAME_BUFFER_SIZE(AVI), INFOFRAME_BUFFER_SIZE(SPD)))
>  
> -static void intel_set_infoframe(struct drm_encoder *encoder,
> -				union hdmi_infoframe *frame)
> +static void intel_write_infoframe(struct drm_encoder *encoder,
> +				  union hdmi_infoframe *frame)
>  {
>  	struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
>  	uint8_t buffer[DIP_BUFFER_SIZE];
> @@ -406,7 +406,7 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder,
>  				HDMI_QUANTIZATION_RANGE_FULL;
>  	}
>  
> -	intel_set_infoframe(encoder, &frame);
> +	intel_write_infoframe(encoder, &frame);
>  }
>  
>  static void intel_hdmi_set_spd_infoframe(struct drm_encoder *encoder)
> @@ -422,7 +422,7 @@ static void intel_hdmi_set_spd_infoframe(struct drm_encoder *encoder)
>  
>  	frame.spd.sdi = HDMI_SPD_SDI_PC;
>  
> -	intel_set_infoframe(encoder, &frame);
> +	intel_write_infoframe(encoder, &frame);
>  }
>  
>  static void g4x_set_infoframes(struct drm_encoder *encoder,
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC