From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/8] drm/i915/hmdi: Rename set_infoframe() to write_infoframe() Date: Mon, 5 Aug 2013 20:50:45 +0300 Message-ID: <20130805175045.GZ5004@intel.com> References: <1375464180-7259-1-git-send-email-damien.lespiau@intel.com> <1375464180-7259-7-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 2885EE7194 for ; Mon, 5 Aug 2013 10:50:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375464180-7259-7-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote: > set_frame() wraps the write_frame() vfunc. Be consistent and name the > wrapping function like the vfunc being called. > = > It's doubly confusing as we also have a set_infoframes() vfunc and > set_infoframe() doesn't wrap it. I guess the logic was = set_infoframes -> set__infoframe -> set_infoframe -> write_infoframe But I don't really have an opinion on which is better, so: Reviewed-by: Ville Syrj=E4l=E4 > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_hdmi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/int= el_hdmi.c > index 57dd413..8424882 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -355,8 +355,8 @@ static void hsw_write_infoframe(struct drm_encoder *e= ncoder, > #define DIP_BUFFER_SIZE \ > (max(INFOFRAME_BUFFER_SIZE(AVI), INFOFRAME_BUFFER_SIZE(SPD))) > = > -static void intel_set_infoframe(struct drm_encoder *encoder, > - union hdmi_infoframe *frame) > +static void intel_write_infoframe(struct drm_encoder *encoder, > + union hdmi_infoframe *frame) > { > struct intel_hdmi *intel_hdmi =3D enc_to_intel_hdmi(encoder); > uint8_t buffer[DIP_BUFFER_SIZE]; > @@ -406,7 +406,7 @@ static void intel_hdmi_set_avi_infoframe(struct drm_e= ncoder *encoder, > HDMI_QUANTIZATION_RANGE_FULL; > } > = > - intel_set_infoframe(encoder, &frame); > + intel_write_infoframe(encoder, &frame); > } > = > static void intel_hdmi_set_spd_infoframe(struct drm_encoder *encoder) > @@ -422,7 +422,7 @@ static void intel_hdmi_set_spd_infoframe(struct drm_e= ncoder *encoder) > = > frame.spd.sdi =3D HDMI_SPD_SDI_PC; > = > - intel_set_infoframe(encoder, &frame); > + intel_write_infoframe(encoder, &frame); > } > = > static void g4x_set_infoframes(struct drm_encoder *encoder, > -- = > 1.8.3.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC