Re: [PATCH 13/29] drm/i915: eliminate dead domain clearing on reset

Daniel Vetter
2013-08-05T17:13:36Z

On Mon, Aug 05, 2013 at 09:46:44AM -0700, Ben Widawsky wrote:
> The code itself is no longer accurate without updating once we have
> multiple address space since clearing the domains of every object
> requires scanning the inactive list for all VMs.
>
> "This code is dead. Just remove it rather than port it to vma." - Chris
> Wilson
>
> Recommended-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>

Thanks for resend, slurped into dinq. I'd like to take a little break here
now and resume merging tomorrow - I've merge over 50 patches just today
;-)
-Daniel

> ---
> drivers/gpu/drm/i915/i915_gem.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index d37f5c0..3b9558f 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2290,20 +2290,12 @@ void i915_gem_restore_fences(struct drm_device *dev)
> void i915_gem_reset(struct drm_device *dev)
> {
> struct drm_i915_private *dev_priv = dev->dev_private;
> - struct i915_address_space *vm = &dev_priv->gtt.base;
> - struct drm_i915_gem_object *obj;
> struct intel_ring_buffer *ring;
> int i;
>
> for_each_ring(ring, dev_priv, i)
> i915_gem_reset_ring_lists(dev_priv, ring);
>
> - /* Move everything out of the GPU domains to ensure we do any
> - * necessary invalidation upon reuse.
> - */
> - list_for_each_entry(obj, &vm->inactive_list, mm_list)
> - obj->base.read_domains &= ~I915_GEM_GPU_DOMAINS;
> -
> i915_gem_restore_fences(dev);
> }
>
> --
> 1.8.3.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch