Re: [PATCH 19/29] drm/i915: turn bound_ggtt checks to bound_any

Ben Widawsky
2013-08-03T22:26:56Z

On Sat, Aug 03, 2013 at 12:03:35PM +0100, Chris Wilson wrote:
> On Wed, Jul 31, 2013 at 05:00:12PM -0700, Ben Widawsky wrote:
> > In some places, we want to know if an object is bound in any address
> > space, and not just the global GTT. This often applies when there is a
> > single global resource (object, pages, etc.)
> >
> > function | reason
> > --------------------------------------------------
> > i915_gem_object_is_inactive | global object
> > i915_gem_object_put_pages | object's pages
> > 915_gem_object_unpin | global object
> > i915_gem_execbuffer_unreserve_object | temporary until we plumb vma
> > pread/pread | object's domain
>
> Most of these we want to operate on ggtt, so this change looks confused
> at best.
> -Chris
>

And at worst? I guess I should have explained it a bit differently - yes
the operations may very well be on the global GTT, but for the given
reason (in the table), we need to make sure we unbind (or assert the
object isn't bound) in another address space first.

Possibly I've misunderstood what you'd like me to do however.

--
Ben Widawsky, Intel Open Source Technology Center