From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 09/13] drm/i915: Split plane watermark
 parameters into a separate struct
Date: Tue, 6 Aug 2013 21:10:19 +0100
Message-ID: <20130806201019.GG8181@cantiga.alporthouse.com>
References: <1375817052-32310-1-git-send-email-ville.syrjala@linux.intel.com>
	<1375817052-32310-10-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (s16502780.onlinehome-server.info
	[87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1F5D8E6BCA
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  6 Aug 2013 13:10:25 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1375817052-32310-10-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 06, 2013 at 10:24:08PM +0300, ville.syrjala@linux.intel.com wro=
te:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Give a name to the plane watermark related data we have currently
> stored under intel_plane->wm.
> =

> We also observe that this data is more or less the same that we have
> in the hsw_pipe_wm_parameters structure, so use it there as well.
> =

> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

> ---
>  drivers/gpu/drm/i915/intel_drv.h | 14 +++++-----
>  drivers/gpu/drm/i915/intel_pm.c  | 57 +++++++++++++++++++---------------=
------
>  2 files changed, 35 insertions(+), 36 deletions(-)
> =

> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/inte=
l_drv.h
> index ed33976..0366bca 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -330,6 +330,13 @@ struct intel_crtc {
>  	bool pch_fifo_underrun_disabled;
>  };
>  =

> +struct intel_plane_wm_parameters {
> +	bool enabled;
> +	bool scaled;
> +	uint8_t bytes_per_pixel;
> +	uint32_t horiz_pixels;

You are no friend to pa-hole.
-Chris

-- =

Chris Wilson, Intel Open Source Technology Centre