From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 07/13] drm/i915: Calculate max watermark
 levels for ILK+
Date: Tue, 6 Aug 2013 21:39:31 +0100
Message-ID: <20130806203931.GL8181@cantiga.alporthouse.com>
References: <1375817052-32310-1-git-send-email-ville.syrjala@linux.intel.com>
	<1375817052-32310-8-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (s16502780.onlinehome-server.info
	[87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0159DE6341
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  6 Aug 2013 13:39:37 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1375817052-32310-8-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 06, 2013 at 10:24:06PM +0300, ville.syrjala@linux.intel.com wro=
te:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> There are quite a few variables we need to take into account to
> determine the maximum watermark levels, so it feels a bit cleaner
> to calculate those rather than just have a bunch of what look like
> magic numbers.

Any chance I can have num_pipes_active? I'm weird, but I keep expecting
pipes_active to a bitmask. (This comment applies to everywhere we have a
x_active counter :)

s/othwerwise/otherwise/
 =

> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Reads well, very well. Checked through a couple of the values, and it
seems consistent,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- =

Chris Wilson, Intel Open Source Technology Centre