From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: do not disable backlight on vgaswitcheroo switch off Date: Wed, 7 Aug 2013 09:52:22 +0200 Message-ID: <20130807075222.GR22035@phenom.ffwll.local> References: <1374751890-9194-1-git-send-email-jani.nikula@intel.com> <87y58eyq1x.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DAE8E66DD for ; Wed, 7 Aug 2013 00:52:15 -0700 (PDT) Received: by mail-we0-f173.google.com with SMTP id x55so1233243wes.18 for ; Wed, 07 Aug 2013 00:52:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87y58eyq1x.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 07, 2013 at 09:26:34AM +0300, Jani Nikula wrote: > On Thu, 25 Jul 2013, Jani Nikula wrote: > > On muxed systems, the other vgaswitcheroo client may depend on i915 to > > handle the backlight. We began switching off the backlight since > > > > commit a261b246ebd552fd5d5a8ed84cc931bb821c427f > > Author: Daniel Vetter > > Date: Thu Jul 26 19:21:47 2012 +0200 > > > > drm/i915: disable all crtcs at suspend time > > > > breaking backlight on discreet graphics in (some) muxed systems. > > > > Keep the backlight on when the state is changed through vgaswitcheroo. > > > > Note: The alternative would be to add a quirk table to achieve the same > > based on system identifiers, but AFAICS it would asymptotically approach > > effectively the same as this patch as more IDs are added, but with the > > maintenance burden of the quirk table. > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=55311 > > Tested-by: Fede > Tested-by: Aximab > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59785 > > Tested-by: sfievet Picked up for -fixes (with a cc: stable), thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch