From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 04/13] drm/i915: Kill fbc_enable from hsw_lp_wm_results
Date: Wed, 7 Aug 2013 12:57:44 +0300 [thread overview]
Message-ID: <20130807095744.GQ5004@intel.com> (raw)
In-Reply-To: <20130806204511.GN8181@cantiga.alporthouse.com>
On Tue, Aug 06, 2013 at 09:45:11PM +0100, Chris Wilson wrote:
> On Tue, Aug 06, 2013 at 10:24:03PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We don't need to store the FBC WM enabled status in each watermark
> > level. We anyway have to reduce it down to a single boolean, so just
> > delay checking the FBC WM limit until we're computing the final
> > value.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The pay-off simply being the reduction of one bool in a temporary
> struct [x3]?
I don't remember anymore if I had a better reason originally.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-08-07 9:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 19:23 [PATCH 00/13] drm/i915: More ILK+ watermark prep patches ville.syrjala
2013-08-06 19:24 ` [PATCH 01/13] drm/i915: Use 'enabled' instead of 'enable' consistentnly in sprite WM code ville.syrjala
2013-08-06 19:36 ` Chris Wilson
2013-08-06 19:24 ` [PATCH 02/13] drm/i915: Pull watermark level validity check out ville.syrjala
2013-08-06 19:41 ` Chris Wilson
2013-08-07 10:24 ` [PATCH v2] " ville.syrjala
2013-08-08 8:59 ` Chris Wilson
2013-08-06 19:24 ` [PATCH 03/13] drm/i915: Split watermark level computation from the code ville.syrjala
2013-08-06 20:56 ` Chris Wilson
2013-08-07 9:56 ` Ville Syrjälä
2013-08-06 19:24 ` [PATCH 04/13] drm/i915: Kill fbc_enable from hsw_lp_wm_results ville.syrjala
2013-08-06 20:45 ` Chris Wilson
2013-08-07 9:57 ` Ville Syrjälä [this message]
2013-08-06 19:24 ` [PATCH 05/13] drm/i915: Rename hsw_data_buf_partitioning to intel_ddb_partitioning ville.syrjala
2013-08-06 20:31 ` Chris Wilson
2013-08-07 8:24 ` Daniel Vetter
2013-08-06 19:24 ` [PATCH 06/13] drm/i915: Rename hsw_lp_wm_result to intel_wm_level ville.syrjala
2013-08-06 20:14 ` Chris Wilson
2013-08-06 19:24 ` [PATCH 07/13] drm/i915: Calculate max watermark levels for ILK+ ville.syrjala
2013-08-06 20:39 ` Chris Wilson
2013-08-07 10:28 ` [PATCH v2] " ville.syrjala
2013-08-06 19:24 ` [PATCH 08/13] drm/i915; Pull some watermarks state into a separate structure ville.syrjala
2013-08-06 19:58 ` Chris Wilson
2013-08-07 10:29 ` [PATCH v2] drm/i915: " ville.syrjala
2013-08-06 19:24 ` [PATCH 09/13] drm/i915: Split plane watermark parameters into a separate struct ville.syrjala
2013-08-06 20:10 ` Chris Wilson
2013-08-07 10:29 ` [PATCH v2] " ville.syrjala
2013-08-06 19:24 ` [PATCH 10/13] drm/i915: Pass crtc to our update/disable_plane hooks ville.syrjala
2013-08-06 20:40 ` Chris Wilson
2013-08-06 19:24 ` [PATCH 11/13] drm/i915: Don't try to disable plane if it's already disabled ville.syrjala
2013-08-06 20:29 ` Chris Wilson
2013-08-07 10:30 ` [PATCH v2] " ville.syrjala
2013-08-06 19:24 ` [PATCH 12/13] drm/i915: Pass plane and crtc to intel_update_sprite_watermarks ville.syrjala
2013-08-06 20:25 ` Chris Wilson
2013-08-06 19:24 ` [PATCH 13/13] drm/i915: Always call intel_update_sprite_watermarks() when disabling a plane ville.syrjala
2013-08-06 20:06 ` Chris Wilson
2013-08-08 9:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807095744.GQ5004@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).