From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [Intel-gfx] [PATCH 04/12] video/hmdi: Clear the whole incoming buffer, not just the infoframe size Date: Wed, 7 Aug 2013 12:02:39 +0100 Message-ID: <20130807110239.GF21449@strange.amr.corp.intel.com> References: <1375817544-14565-1-git-send-email-damien.lespiau@intel.com> <1375817544-14565-5-git-send-email-damien.lespiau@intel.com> <20130807105658.GT5004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20130807105658.GT5004@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 07, 2013 at 01:56:58PM +0300, Ville Syrj=E4l=E4 wrote: > On Tue, Aug 06, 2013 at 08:32:16PM +0100, Damien Lespiau wrote: > > If the user if this API is providing a bigger buffer than the infoframe > > size, it could be for a could reason. For instance it could be because > > it gives the buffer that will be written to the hardware, up to the > > maximum of an infoframe size. > > = > > Instead of just zeroing up to the infoframe size, let's zero the whole > > incoming buffer as those extra bytes are also used to compute the > > ECC and need to be 0. > > = > > Signed-off-by: Damien Lespiau > = > One concern that came to mind was someone needing to preserve the buffer > contents beyond the infoframe. But I guess if someone really needs to > do that, they can go and figure out the exact length of the infoframe > and pass that. Right, that was my thinking as well. We even have a macro for that now. -- = Damien