From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 4/9] drm/i915: don't update GEN6_PMIMR when
 it's not needed
Date: Wed, 7 Aug 2013 15:14:51 +0100
Message-ID: <20130807141451.GA16248@cantiga.alporthouse.com>
References: <1375826239-3060-1-git-send-email-przanoni@gmail.com>
	<1375826239-3060-5-git-send-email-przanoni@gmail.com>
	<20130807003508.GA10740@cantiga.alporthouse.com>
	<CA+gsUGTCJe=RPzT4_K0GPt62uWAA0ZdocVYRFmvJFu9=oUpiBA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (s16502780.onlinehome-server.info
	[87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id 14DC4E6A72
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  7 Aug 2013 07:15:05 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGTCJe=RPzT4_K0GPt62uWAA0ZdocVYRFmvJFu9=oUpiBA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Aug 07, 2013 at 10:34:11AM -0300, Paulo Zanoni wrote:
> 2013/8/6 Chris Wilson <chris@chris-wilson.co.uk>:
> > On Tue, Aug 06, 2013 at 06:57:14PM -0300, Paulo Zanoni wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> I did some brief tests and the "new_val = pmimr" condition usually
> >> happens a few times after exiting games.
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > I'm not sure of the value of this patch by itself. It did make me wonder
> > what you were micro-optimising, and then I saw patch 5 and it made more
> > sense.
> 
> Patches 4 and 5 are just micro optimizations and shouldn't be needed
> for the PC8+, but I thought they would be useful. If you think they're
> not worth it, we can discard them. I was trying to make the code
> similar to the other IMR-changing functions.

Combined together, I think the micro-optimisation makes sense and would
say it was less of a micro-optimisation than a consistent design to use
the bookkeeping instead of touching registers. Just on its own this
patch caused me to do a double-take and question what your motivation
was.
 
> If we massage the code a little bit more we could make all the
> IMR-changing functions share the same code

Sure, that may be worthwhile. Probably borderline though, I envisage it
will take more code to setup than it will save.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre