From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/edid: Fix add_cea_modes() style issues
Date: Wed, 7 Aug 2013 22:48:12 +0300 [thread overview]
Message-ID: <20130807194812.GX5004@intel.com> (raw)
In-Reply-To: <1375900754-3574-2-git-send-email-damien.lespiau@intel.com>
On Wed, Aug 07, 2013 at 07:39:13PM +0100, Damien Lespiau wrote:
> A few styles issues have creept in here, fix them before touching this
> code again.
You could also sprinke a bit of constness into these functions while
you're touching them.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 95d6f4b..51342c4 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -2442,10 +2442,10 @@ add_alternate_cea_modes(struct drm_connector *connector, struct edid *edid)
> }
>
> static int
> -do_cea_modes (struct drm_connector *connector, u8 *db, u8 len)
> +do_cea_modes(struct drm_connector *connector, u8 *db, u8 len)
> {
> struct drm_device *dev = connector->dev;
> - u8 * mode, cea_mode;
> + u8 *mode, cea_mode;
> int modes = 0;
>
> for (mode = db; mode < db + len; mode++) {
> @@ -2502,8 +2502,8 @@ cea_db_offsets(const u8 *cea, int *start, int *end)
> static int
> add_cea_modes(struct drm_connector *connector, struct edid *edid)
> {
> - u8 * cea = drm_find_cea_extension(edid);
> - u8 * db, dbl;
> + u8 *cea = drm_find_cea_extension(edid);
> + u8 *db, dbl;
> int modes = 0;
>
> if (cea && cea_revision(cea) >= 3) {
> @@ -2517,7 +2517,7 @@ add_cea_modes(struct drm_connector *connector, struct edid *edid)
> dbl = cea_db_payload_len(db);
>
> if (cea_db_tag(db) == VIDEO_BLOCK)
> - modes += do_cea_modes (connector, db+1, dbl);
> + modes += do_cea_modes(connector, db + 1, dbl);
> }
> }
>
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-08-07 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 18:39 HDMI 4k support Damien Lespiau
2013-08-07 18:39 ` [PATCH 1/2] drm/edid: Fix add_cea_modes() style issues Damien Lespiau
2013-08-07 19:48 ` Ville Syrjälä [this message]
2013-08-07 18:39 ` [PATCH 2/2] drm/edid: Parse the HDMI CEA block and look for 4k modes Damien Lespiau
2013-08-07 19:45 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807194812.GX5004@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox