From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/edid: Fix add_cea_modes() style issues Date: Wed, 7 Aug 2013 22:48:12 +0300 Message-ID: <20130807194812.GX5004@intel.com> References: <1375900754-3574-1-git-send-email-damien.lespiau@intel.com> <1375900754-3574-2-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1375900754-3574-2-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 07, 2013 at 07:39:13PM +0100, Damien Lespiau wrote: > A few styles issues have creept in here, fix them before touching this > code again. You could also sprinke a bit of constness into these functions while you're touching them. > = > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/drm_edid.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 95d6f4b..51342c4 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2442,10 +2442,10 @@ add_alternate_cea_modes(struct drm_connector *con= nector, struct edid *edid) > } > = > static int > -do_cea_modes (struct drm_connector *connector, u8 *db, u8 len) > +do_cea_modes(struct drm_connector *connector, u8 *db, u8 len) > { > struct drm_device *dev =3D connector->dev; > - u8 * mode, cea_mode; > + u8 *mode, cea_mode; > int modes =3D 0; > = > for (mode =3D db; mode < db + len; mode++) { > @@ -2502,8 +2502,8 @@ cea_db_offsets(const u8 *cea, int *start, int *end) > static int > add_cea_modes(struct drm_connector *connector, struct edid *edid) > { > - u8 * cea =3D drm_find_cea_extension(edid); > - u8 * db, dbl; > + u8 *cea =3D drm_find_cea_extension(edid); > + u8 *db, dbl; > int modes =3D 0; > = > if (cea && cea_revision(cea) >=3D 3) { > @@ -2517,7 +2517,7 @@ add_cea_modes(struct drm_connector *connector, stru= ct edid *edid) > dbl =3D cea_db_payload_len(db); > = > if (cea_db_tag(db) =3D=3D VIDEO_BLOCK) > - modes +=3D do_cea_modes (connector, db+1, dbl); > + modes +=3D do_cea_modes(connector, db + 1, dbl); > } > } > = > -- = > 1.8.3.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC