From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 13/13] drm/i915: Always call intel_update_sprite_watermarks() when disabling a plane Date: Thu, 8 Aug 2013 11:51:03 +0200 Message-ID: <20130808095103.GJ22035@phenom.ffwll.local> References: <1375817052-32310-1-git-send-email-ville.syrjala@linux.intel.com> <1375817052-32310-14-git-send-email-ville.syrjala@linux.intel.com> <20130806200616.GF8181@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com [209.85.215.176]) by gabe.freedesktop.org (Postfix) with ESMTP id B4561E6157 for ; Thu, 8 Aug 2013 02:50:57 -0700 (PDT) Received: by mail-ea0-f176.google.com with SMTP id q16so1301133ead.21 for ; Thu, 08 Aug 2013 02:50:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130806200616.GF8181@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 06, 2013 at 09:06:16PM +0100, Chris Wilson wrote: > On Tue, Aug 06, 2013 at 10:24:12PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > ILK and VLV codepaths didn't update sprite watermarks when disabling a > > sprite. Make them do that. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > = > I am totally loving the naming confusion between intel_plane and > intel_sprite in intel_display.c. There when we refer to a plane, we may > mean a slice of the CRTC pipeline or what we refer elsewhere as a sprite. > = > e.g. intel_disable_plane and intel_plane_disable. > = > Having got past that to realise this is intel_sprite.c not > intel_display.c, > Reviewed->by: Chris Wilson All merged to dinq, thanks for patches&review. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch