* [patch] drm/i915: unbreak i915_gem_object_ggtt_unbind()
@ 2013-08-09 9:44 Dan Carpenter
2013-08-09 10:05 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-08-09 9:44 UTC (permalink / raw)
To: Daniel Vetter; +Cc: David Airlie, intel-gfx, dri-devel, kernel-janitors
There is an extra semi-colon here so we just leak and never unbind
anything.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 735f43f..a582540 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2656,7 +2656,7 @@ i915_gem_object_ggtt_unbind(struct drm_i915_gem_object *obj)
struct drm_i915_private *dev_priv = obj->base.dev->dev_private;
struct i915_address_space *ggtt = &dev_priv->gtt.base;
- if (!i915_gem_obj_ggtt_bound(obj));
+ if (!i915_gem_obj_ggtt_bound(obj))
return 0;
if (obj->pin_count)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] drm/i915: unbreak i915_gem_object_ggtt_unbind()
2013-08-09 9:44 [patch] drm/i915: unbreak i915_gem_object_ggtt_unbind() Dan Carpenter
@ 2013-08-09 10:05 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2013-08-09 10:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Daniel Vetter, David Airlie, intel-gfx, dri-devel,
kernel-janitors, Ben Widawsky
On Fri, Aug 09, 2013 at 12:44:11PM +0300, Dan Carpenter wrote:
> There is an extra semi-colon here so we just leak and never unbind
> anything.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 735f43f..a582540 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2656,7 +2656,7 @@ i915_gem_object_ggtt_unbind(struct drm_i915_gem_object *obj)
> struct drm_i915_private *dev_priv = obj->base.dev->dev_private;
> struct i915_address_space *ggtt = &dev_priv->gtt.base;
>
> - if (!i915_gem_obj_ggtt_bound(obj));
> + if (!i915_gem_obj_ggtt_bound(obj))
Oops, thanks for spotting this. Applied to dinq.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-09 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 9:44 [patch] drm/i915: unbreak i915_gem_object_ggtt_unbind() Dan Carpenter
2013-08-09 10:05 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox