From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/5] drm/i915: WARN_ON failed map_and_fenceable Date: Sat, 10 Aug 2013 10:58:30 +0200 Message-ID: <20130810085830.GH31670@phenom.ffwll.local> References: <1376111536-12461-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id B4003E652B for ; Sat, 10 Aug 2013 01:58:22 -0700 (PDT) Received: by mail-ee0-f42.google.com with SMTP id b45so2499613eek.15 for ; Sat, 10 Aug 2013 01:58:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1376111536-12461-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: > I just noticed in our code we don't really check the assertion, and > given some of the code I am changing in this area, I feel a WARN is very > nice to have. > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 498ef8a..b91a7f0 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -3186,6 +3186,8 @@ search_free: > if (i915_is_ggtt(vm)) > obj->map_and_fenceable = mappable && fenceable; > > + WARN_ON(map_and_fenceable & !obj->map_and_fenceable); s/&/&&/ I think, although since both are bools it doesn't matter correctness-wise. -Daniel > + > trace_i915_vma_bind(vma, map_and_fenceable); > i915_gem_verify_gtt(dev); > return 0; > -- > 1.8.3.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch