From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/5] drm/i915: bind m&f cleanup Date: Mon, 12 Aug 2013 17:17:26 -0700 Message-ID: <20130813001726.GA19113@bwidawsk.net> References: <1376111536-12461-1-git-send-email-benjamin.widawsky@intel.com> <1376111536-12461-2-git-send-email-benjamin.widawsky@intel.com> <20130810084116.GB3561@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FDFFE6A8C for ; Mon, 12 Aug 2013 17:17:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130810084116.GB3561@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Sat, Aug 10, 2013 at 09:41:16AM +0100, Chris Wilson wrote: > On Fri, Aug 09, 2013 at 10:12:13PM -0700, Ben Widawsky wrote: > > Cleanup the map and fenceable setting during bind to make more sense, > > and not check i915_is_ggtt() 2 unnecessary times > > > > Recommended-by: Chris Wilson > > Signed-off-by: Ben Widawsky > > There were a couple of bools that only exist to make this computation > more readable that could be moved to this block. > -Chris > I saw these. The cleanup is somewhat involved, so I punted on it. I'll implement it now, but I expect you to review it. -- Ben Widawsky, Intel Open Source Technology Center