From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level
Date: Tue, 13 Aug 2013 12:38:31 +0200 [thread overview]
Message-ID: <20130813103831.GC9296@phenom.ffwll.local> (raw)
In-Reply-To: <20130813075448.GB9296@phenom.ffwll.local>
On Tue, Aug 13, 2013 at 09:54:48AM +0200, Daniel Vetter wrote:
> On Mon, Aug 12, 2013 at 11:46:17AM +0100, Chris Wilson wrote:
> > By our earlier reckoning, move from a snooped/llc setting to an uncached
> > setting, leaves the CPU cache in a consistent state irrespective of our
> > domain tracking - so we can forgo the warning about the lack of
> > invalidation. Similarly for any writes posted to the snooped CPU domain,
> > we know will be safely clflushed to the uncached PTEs after forcing the
> > domain change.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68040
> Tested-by: cancan,feng <cancan.feng@intel.com>
Oh and QA blames that this WARN newly pops up on
commit d46f1c3f1372e3a72fab97c60480aa4a1084387f
Author: Chris Wilson <chris@chris-wilson.co.uk>
AuthorDate: Thu Aug 8 14:41:06 2013 +0100
Commit: Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Sat Aug 10 11:24:18 2013 +0200
drm/i915: Allow the GPU to cache stolen memory
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-08-13 10:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 10:46 [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level Chris Wilson
2013-08-12 21:02 ` Ben Widawsky
2013-08-12 21:29 ` Chris Wilson
2013-08-13 7:54 ` Daniel Vetter
2013-08-13 10:38 ` Daniel Vetter [this message]
2013-08-13 12:12 ` Ville Syrjälä
2013-08-13 12:20 ` Chris Wilson
2013-08-13 12:37 ` Ville Syrjälä
2013-08-14 8:49 ` Daniel Vetter
2013-08-14 8:54 ` Chris Wilson
2013-08-14 10:01 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2013-08-13 10:08 Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813103831.GC9296@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox