From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Drop the overzealous warning from
 i915_gem_set_cache_level
Date: Tue, 13 Aug 2013 12:38:31 +0200
Message-ID: <20130813103831.GC9296@phenom.ffwll.local>
References: <1376304377-11695-1-git-send-email-chris@chris-wilson.co.uk>
	<20130813075448.GB9296@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com
	[209.85.215.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0C0E5E6120
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Aug 2013 03:38:23 -0700 (PDT)
Received: by mail-ea0-f177.google.com with SMTP id f15so3959463eak.8
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Aug 2013 03:38:23 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130813075448.GB9296@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 13, 2013 at 09:54:48AM +0200, Daniel Vetter wrote:
> On Mon, Aug 12, 2013 at 11:46:17AM +0100, Chris Wilson wrote:
> > By our earlier reckoning, move from a snooped/llc setting to an uncached
> > setting, leaves the CPU cache in a consistent state irrespective of our
> > domain tracking - so we can forgo the warning about the lack of
> > invalidation. Similarly for any writes posted to the snooped CPU domain,
> > we know will be safely clflushed to the uncached PTEs after forcing the
> > domain change.
> > =

> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D68040
> Tested-by: cancan,feng <cancan.feng@intel.com>

Oh and QA blames that this WARN newly pops up on

commit d46f1c3f1372e3a72fab97c60480aa4a1084387f
Author:     Chris Wilson <chris@chris-wilson.co.uk>
AuthorDate: Thu Aug 8 14:41:06 2013 +0100
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Sat Aug 10 11:24:18 2013 +0200

    drm/i915: Allow the GPU to cache stolen memory

-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch