Re: [PATCH] drm/i915: Drop the overzealous warning from i915_gem_set_cache_level

Daniel Vetter
2013-08-13T10:38:23Z

On Tue, Aug 13, 2013 at 09:54:48AM +0200, Daniel Vetter wrote:
> On Mon, Aug 12, 2013 at 11:46:17AM +0100, Chris Wilson wrote:
> > By our earlier reckoning, move from a snooped/llc setting to an uncached
> > setting, leaves the CPU cache in a consistent state irrespective of our
> > domain tracking - so we can forgo the warning about the lack of
> > invalidation. Similarly for any writes posted to the snooped CPU domain,
> > we know will be safely clflushed to the uncached PTEs after forcing the
> > domain change.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68040
> Tested-by: cancan,feng <cancan.feng@intel.com>

Oh and QA blames that this WARN newly pops up on

commit d46f1c3f1372e3a72fab97c60480aa4a1084387f
Author: Chris Wilson <chris@chris-wilson.co.uk>
AuthorDate: Thu Aug 8 14:41:06 2013 +0100
Commit: Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Sat Aug 10 11:24:18 2013 +0200

drm/i915: Allow the GPU to cache stolen memory

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch