From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 3/4] drm: WARN when removing unallocated node Date: Wed, 14 Aug 2013 10:52:36 +0200 Message-ID: <20130814085236.GQ9296@phenom.ffwll.local> References: <1376442549-5087-1-git-send-email-benjamin.widawsky@intel.com> <1376442549-5087-3-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1376442549-5087-3-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, Ben Widawsky , dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 13, 2013 at 06:09:08PM -0700, Ben Widawsky wrote: > The conditional is usually a recoverable driver bug, and so WARNing, and > preventing the drm_mm code from doing potential damage (BUG) is > desirable. > > This issue was hit and fixed twice while developing the i915 multiple > address space code. The first fix is the patch just before this, and is > hit on an not frequently occuring error path. Another was fixed during > patch iteration, so it's hard to see from the patch: > > commit c6cfb325677ea6305fb19acf3a4d14ea267f923e > Author: Ben Widawsky > Date: Fri Jul 5 14:41:06 2013 -0700 > > drm/i915: Embed drm_mm_node in i915 gem obj > > From the intel-gfx mailing list, we discussed this: > References: <20130705191235.GA3057@bwidawsk.net> > > Cc: Dave Airlie > CC: > Acked-by: Chris Wilson > Signed-off-by: Ben Widawsky Patches 2&3 of this series are merged to dinq, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch