From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: inline vma_create into lookup_or_create_vma Date: Wed, 14 Aug 2013 14:08:54 +0200 Message-ID: <20130814120854.GT9296@phenom.ffwll.local> References: <1376473116-21874-5-git-send-email-daniel.vetter@ffwll.ch> <1376474349-30928-1-git-send-email-daniel.vetter@ffwll.ch> <20130814114904.GA14128@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f171.google.com (mail-ea0-f171.google.com [209.85.215.171]) by gabe.freedesktop.org (Postfix) with ESMTP id C42F3E66D9 for ; Wed, 14 Aug 2013 05:08:47 -0700 (PDT) Received: by mail-ea0-f171.google.com with SMTP id n15so4797481ead.30 for ; Wed, 14 Aug 2013 05:08:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130814114904.GA14128@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , Daniel Vetter , Intel Graphics Development , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 14, 2013 at 12:49:04PM +0100, Chris Wilson wrote: > On Wed, Aug 14, 2013 at 11:59:09AM +0200, Daniel Vetter wrote: > > In the execbuf code we don't clean up any vmas which ended up not > > getting bound for code simplicity. To make sure that we don't end up > > creating multiple vma for the same vm kill the somewhat dangerous > > vma_create function and inline it into lookup_or_create. > > Just make it static. It's a nice little standalone function that helps > the reader. I'm afraid that someone will use it eventually. I'll smash a __ prefix onto it to make it clear that people better don't touch it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch